Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load inquirer module #333

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

bertdeblock
Copy link
Member

Because eagerly loading heavy modules slows down every ember command.
This change makes a difference of about 50ms.

@bertdeblock bertdeblock reopened this Feb 21, 2024
@bertdeblock
Copy link
Member Author

@NullVoxPopuli CI passes.

@NullVoxPopuli NullVoxPopuli merged commit a4d8fd9 into emberjs:master Feb 21, 2024
6 checks passed
@NullVoxPopuli NullVoxPopuli added the enhancement New feature or request label Feb 21, 2024
@github-actions github-actions bot mentioned this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants